Avoid using block_given in the presence of aliases #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #41 ostruct.rb was modified to not define
block_given!on JRuby because it would not be recognized as being the same asblock_given?and would not work properly (and we would also warn about this situation).Unfortunately,
each_pairstill expectsblock_given!to be defined:https://github.com/ruby/ostruct/blob/master/lib/ostruct.rb#L200
This leads to two failures running on JRuby:
This can be fixed by either using the un-aliased
block_given?on JRuby, or just usingdefined?(yield)which does not requireblock_given?to be available. I have done the latter here.