Skip to content

Avoid an array allocation per element in list passed to seplist #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Apr 22, 2025
Merged

Avoid an array allocation per element in list passed to seplist #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf6df0
Avoid an array allocation per element in list passed to seplist
jeremyevans Apr 20, 2025
efe5bc8
Rename EMPTY_HASH to EMPTY_KWHASH
jeremyevans Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/pp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,15 +276,20 @@ def comma_breakable
def seplist(list, sep=nil, iter_method=:each) # :yield: element
sep ||= lambda { comma_breakable }
first = true
kwsplat = EMPTY_KWHASH
list.__send__(iter_method) {|*v|
if first
first = false
else
sep.call
end
RUBY_VERSION >= "3.0" ? yield(*v, **{}) : yield(*v)
kwsplat ? yield(*v, **kwsplat) : yield(*v)
}
end
EMPTY_KWHASH = if RUBY_VERSION >= "3.0"
{}.freeze
end
private_constant :EMPTY_KWHASH

# A present standard failsafe for pretty printing any given Object
def pp_object(obj)
Expand Down
Loading