give _ToProc#to_proc a return type#1223
Merged
soutaro merged 1 commit intoruby:masterfrom Feb 6, 2023
ParadoxV5:_ToProc
Merged
give _ToProc#to_proc a return type#1223soutaro merged 1 commit intoruby:masterfrom ParadoxV5:_ToProc
_ToProc#to_proc a return type#1223soutaro merged 1 commit intoruby:masterfrom
ParadoxV5:_ToProc
Conversation
Contributor
Author
|
[Discussion] just typing it as
Regardless of which bullet point to adopt, |
soutaro
approved these changes
Feb 6, 2023
Member
|
Thanks @ParadoxV5, Having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don’t know what purpose are the interfaces in
builtin.rbs, but I do use them for implicit conversion. The return of_ToProc#to_proc, however, is untyped and I cannot see why. This is the contract for implicit conversion to a block when prefixed with&(an_array.map(&a_to_proc)).