Closed
Conversation
Contributor
sampersand
commented
Jul 5, 2024
sampersand
commented
- part 1, finished allbut coercion
- i think i got em
- everything but two methods
- more tests
- more tests, now just for coerce and enumerators
- partx?
- x
Contributor
|
Welcome back, brother. |
ParadoxV5
reviewed
Jul 5, 2024
Comment on lines
-1267
to
-1301
| | (2) -> String | ||
| | (3) -> String | ||
| | (4) -> String | ||
| | (5) -> String | ||
| | (6) -> String | ||
| | (7) -> String | ||
| | (8) -> String | ||
| | (9) -> String | ||
| | (10) -> String | ||
| | (11) -> String | ||
| | (12) -> String | ||
| | (13) -> String | ||
| | (14) -> String | ||
| | (15) -> String | ||
| | (16) -> String | ||
| | (17) -> String | ||
| | (18) -> String | ||
| | (19) -> String | ||
| | (20) -> String | ||
| | (21) -> String | ||
| | (22) -> String | ||
| | (23) -> String | ||
| | (24) -> String | ||
| | (25) -> String | ||
| | (26) -> String | ||
| | (27) -> String | ||
| | (28) -> String | ||
| | (29) -> String | ||
| | (30) -> String | ||
| | (31) -> String | ||
| | (32) -> String | ||
| | (33) -> String | ||
| | (34) -> String | ||
| | (35) -> String | ||
| | (36) -> String |
Contributor
There was a problem hiding this comment.
These were probably to represent that integer.to_s(69) is an error.
But this error is literally not a type error:
42.to_s 'a' # TypeError
42.to_s 69 # ArgumentErrorNot to mention how’d this error arise in production…
sampersand
force-pushed
the
swesterman/24-07-04/integer
branch
2 times, most recently
from
a6f39ee to
0329b97
Compare
sampersand
force-pushed
the
swesterman/24-07-04/integer
branch
from
0329b97 to
b85cd82
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.