Skip to content

Use erb instead of set for load path testing #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soutaro merged 1 commit into from
May 1, 2025
Merged

Use erb instead of set for load path testing #2439

soutaro merged 1 commit into from
May 1, 2025

Conversation

@st0012
Copy link
Member

@st0012 st0012 commented May 1, 2025

The recent CI failure seems to be related to ruby/ruby#13074. So changing the testing target to erb should resolve it.

@st0012 st0012 marked this pull request as ready for review May 1, 2025 03:06
@st0012 st0012 changed the title Use erb instead of set for load path testing Use erb instead of set for load path testing May 1, 2025
@soutaro soutaro added this to the RBS 4.0 milestone May 1, 2025
soutaro
soutaro approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@soutaro soutaro added this pull request to the merge queue May 1, 2025
Merged via the queue into ruby:master with commit 90f564c May 1, 2025
20 checks passed
@soutaro soutaro mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

RBS 4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012 @soutaro