Add signatures for some String methods #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [`strip`](http://ruby-doc.org/core-2.6.3/String.html#method-i-strip) - [`strip!`](http://ruby-doc.org/core-2.6.3/String.html#method-i-strip-21) - [`casecmp`](http://ruby-doc.org/core-2.6.3/String.html#method-i-casecmp) - [`casecmp?`](http://ruby-doc.org/core-2.6.3/String.html#method-i-casecmp-3F)
Member
|
@ybiquitous Thanks! 🎉 |
soutaro
pushed a commit
that referenced
this pull request
May 2, 2025
… some cleanups (#26) Part of Shopify/team-ruby-dx#1436 In addition to merging the files, I also did some cleanups like: - Remove unused function declaration - Make some helper functions that aren't referenced outside of C library AND doesn't look like public API as static - A leftover in #25 I recommend reviewing by commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds signatures of the methods below:
stripstrip!casecmpcasecmp?The ruby-doc.org API documentation helps me write these changes.
If this PR does not follow the repository manner, please tell me the correct one. I'm prepare to follow.
Thanks.
See also #1