Remove logger from sig dependencies#2904
Merged
soutaro merged 2 commits intoruby:masterfrom Apr 9, 2026
Merged
Conversation
Because `logger` was removed from manifest.yaml, the validate task needs to explicitly load the logger library when validating rbs signatures, as sig/rbs.rbs references ::Logger. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because there is a dependency on
loggervia manifest.yaml, rbs_collection.lock.yaml is being generated to load the stdlibloggerwhen reading signatures from the rbs-gem.I removed
loggerfrom manifest.yaml and modify it to load signatures from gem_rbs_collection instead.