Skip to content

ruby-head #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soutaro merged 3 commits into from
Oct 17, 2019
Merged

ruby-head #34

soutaro merged 3 commits into from
Oct 17, 2019

Conversation

@hanachin
Copy link
Contributor

@hanachin hanachin commented Oct 16, 2019

Fix #33

@hanachin hanachin marked this pull request as ready for review October 17, 2019 00:36
soutaro
soutaro approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro merged commit e92f6b0 into ruby:master Oct 17, 2019
@hanachin hanachin deleted the fix-for-ruby-head branch December 29, 2019 15:56
soutaro pushed a commit that referenced this pull request May 2, 2025
@st0012
Rename rbs_location.* and rbs_string.* to location.* and `strin…
496bfef 
…g.*` (#34)

This aligns with the naming convention of Prism:

- Private headers are prefixed with `rbs_` and placed under
`include/rbs/util/`.
- Public headers are placed under `include/rbs/` without the `rbs_`
prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ruby-head builds fail

2 participants

@hanachin @soutaro