Change IOGate back to GeneralIO #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staying with ANSI can cause side effects with other tests.
st0012
reviewed
Jan 10, 2023
Member
There was a problem hiding this comment.
Shouldn't we reset the IOGate in Reline.test_reset? Now it's like
- Run
test_mode - Run the test
- Run
test_modeagain to unset just one of the setup it did - Run
test_reset
IMO this has some problems:
- Most of
test_modedoesn't need to be run again but now it is. - It confuses users about the intention of
test_mode. - Now we need 2 helpers to reset the test environment instead of just 1.
Contributor
Author
Agreed and done! |
Closed
ima1zumi
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid side effects to other tests in ruby/ruby.