Skip to content

Add key bindings for PgUp and PgDn #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ima1zumi merged 2 commits into from
Mar 21, 2023
Merged

Add key bindings for PgUp and PgDn #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2acd69b
Add key bindings for PgUp, PgDn
sshock Feb 4, 2023
4851d7b
Match behavior of readline 8.2
sshock Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/reline/ansi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ class Reline::ANSI
'khome' => :ed_move_to_beg,
'kend' => :ed_move_to_end,
'kdch1' => :key_delete,
'kpp' => :ed_search_prev_history,
'knp' => :ed_search_next_history,
'kcuu1' => :ed_prev_history,
'kcud1' => :ed_next_history,
'kcuf1' => :ed_next_char,
Expand Down
14 changes: 14 additions & 0 deletions test/reline/test_ansi_with_terminfo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,20 @@ def test_kdch1
omit e.message
end

# PgUp key
def test_kpp
assert_key_binding(Reline::Terminfo.tigetstr('kpp'), :ed_search_prev_history)
rescue Reline::Terminfo::TerminfoError => e
omit e.message
end

# PgDn key
def test_knp
assert_key_binding(Reline::Terminfo.tigetstr('knp'), :ed_search_next_history)
rescue Reline::Terminfo::TerminfoError => e
omit e.message
end

# Up arrow key
def test_kcuu1
assert_key_binding(Reline::Terminfo.tigetstr('kcuu1'), :ed_prev_history)
Expand Down