Skip to content

Align completion menu items like Readline in noautocomplete mode #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ima1zumi merged 1 commit into from
Apr 1, 2024
Merged

Align completion menu items like Readline in noautocomplete mode #613

ima1zumi merged 1 commit into from
Apr 1, 2024

Conversation

@tompng
Copy link
Member

@tompng tompng commented Nov 29, 2023 •
edited
Loading

Align completion candidates in tab completion(noautocomplete mode) just like Readline.

completion_align

Implementation

Uses each_slice and transpose.
Adding [nil] * n before each_slice to avoid element size differs error in transpose.

ima1zumi
ima1zumi approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@ima1zumi ima1zumi merged commit a622704 into ruby:master Apr 1, 2024
matzbot pushed a commit to ruby/ruby that referenced this pull request Apr 1, 2024
@tompng @matzbot
[ruby/reline] Align completion menu items
508bddc 
(ruby/reline#613)

ruby/reline@a622704f62
@ima1zumi ima1zumi added the enhancement New feature or request label Apr 1, 2024
@tompng tompng deleted the align_menu_info branch April 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @ima1zumi