Add cursor keys for application keypad mode to default key bindings #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
application_key_cursors
branch
from
ca3b3d8 to
3dc856a
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 7, 2024
key bindings (ruby/reline#719) * Add SS3 arrow sequence to default key bindings * Remove wrong KDE arrow sequence ruby/reline@546a42522e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SS3 cursor keys to
set_default_key_bindings_ansi_cursorAdded
\eOA \eOB \eOC \eOD \eOF \eOH(arrow keys, home key, end key for application mode) to default key bindings.Adding this, we can reduce
set_default_key_bindings_comprehensive_list.We added ANSI CSI cursor keys in #569.
This pull request adds SS3 keys that we forgot to add. https://vt100.net/docs/vt100-ug/chapter3.html#T3-6
Removing \eGA \eGB \eGC \eGD
Removed them because these are not specified in terminfo for any terminal emulator.
I think the bytes
[27, 71, 65..68]is a mistake of[27, 79, 65..68]In KDE source code, arrow keys are
CSI + (A|B|C|D)orSS3 + (A|B|C|D)https://invent.kde.org/utilities/konsole/-/blob/master/data/keyboard-layouts/default.keytab?ref_type=heads#L62-72