Skip to content

itunes: add support for parsing <itunes:title> in <item> #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Jul 5, 2023
Merged

itunes: add support for parsing <itunes:title> in <item> #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rss/itunes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ def append_features(klass)
["image", :attribute, "href"],
["season", :positive_integer],
["episode", :positive_integer],
["title"]
]

class ITunesImage < Element
Expand Down
15 changes: 15 additions & 0 deletions test/test-itunes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ def test_episode
end
end

def test_title
assert_itunes_title(%w(items last)) do |content, xmlns|
make_rss20(make_channel20(make_item20(content)), xmlns)
end
end

private
def itunes_rss20_parse(content, &maker)
xmlns = {"itunes" => "http://www.itunes.com/dtds/podcast-1.0.dtd"}
Expand All @@ -133,6 +139,15 @@ def assert_itunes_author(readers, &rss20_maker)
end
end

def assert_itunes_title(readers, &rss20_maker)
_wrap_assertion do
title = "Interview with John Lennon"
rss20 = itunes_rss20_parse(tag("itunes:title", title), &rss20_maker)
target = chain_reader(rss20, readers)
assert_equal(title, target.itunes_title)
end
end

def _assert_itunes_block(value, boolean_value, readers, &rss20_maker)
rss20 = itunes_rss20_parse(tag("itunes:block", value), &rss20_maker)
target = chain_reader(rss20, readers)
Expand Down