Skip to content

itunes: support lowercased episodeType values #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jun 27, 2024
Merged

itunes: support lowercased episodeType values #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3e385
itunes: support for lowercased episodeType values
liberlanco Dec 29, 2023
7ff5f25
Accept only, e.g., Full / full, not FULL, fULL, etc
ozydingo Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rss/rss.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ def itunes_episode_type_writer(name, disp_name=name)
module_eval(<<-DEF, *get_file_and_line_from_caller(2))
def #{name}=(new_value)
if @do_validate and
!["Full", "Trailer", "Bonus", nil].include?(new_value)
!["Full", "full", "Trailer", "trailer", "Bonus", "bonus", nil].include?(new_value)
Copy link
Contributor Author

@ozydingo ozydingo Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou note here your comment from the original PR is addressed

raise NotAvailableValueError.new('#{disp_name}', new_value)
end
@#{name} = new_value
Expand Down
2 changes: 2 additions & 0 deletions test/test-itunes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,8 @@ def assert_itunes_episodeType(readers, &rss20_maker)
_wrap_assertion do
assert_equal("Trailer",
set_itunes_episodeType("Trailer", readers, &rss20_maker))
assert_equal("trailer",
set_itunes_episodeType("trailer", readers, &rss20_maker))
assert_raise(NotAvailableValueError.new("episodeType", "Unknown")) do
set_itunes_episodeType("Unknown", readers, &rss20_maker)
end
Expand Down