Backport https://github.com/ruby/ruby/pull/9673 for Ruby 3.3 #10350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
backport-rbinstall
branch
2 times, most recently
from
691fab8 to
7cda748
Compare
Member
Author
|
This PR is incomplete yet. We need to fix #9673 (comment) |
Member
Author
|
I fixed that. This PR is ready for merge. |
hsbt
changed the title
hsbt
force-pushed
the
backport-rbinstall
branch
from
d54296e to
fb8ad0c
Compare
Instead of hardcoded "ext".
So that it also includes requirable features provided by extensions.
It holds the root directory for each type of default gem (ext/ or lib/).
We need to purge `git ls-files` from gemspec in default gems.
hsbt
force-pushed
the
backport-rbinstall
branch
from
fb8ad0c to
864cca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to fix issue at #9673. But #9673 may have cross-build issue.
I'm investigating that now.