ZJIT: Fix disasm tests on release build #14612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
zjit-fix-disasm
branch
3 times, most recently
from
087e546 to
3566dd7
Compare
k0kubun
force-pushed
the
zjit-fix-disasm
branch
from
3566dd7 to
0fddc04
Compare
k0kubun
force-pushed
the
zjit-fix-disasm
branch
from
9e02037 to
7ed1eb7
Compare
st0012
reviewed
Sep 19, 2025
| let cb = compile(|cb| add(cb, X0, X1, X2)); | ||
| assert_snapshot!(cb.disasm(), @" 0x0: add x0, x1, x2"); | ||
| assert_snapshot!(cb.string(), @"2000028b"); | ||
| cb.with_disasm(|disasm| assert_snapshot!(disasm, @" 0x0: add x0, x1, x2")); |
Member
There was a problem hiding this comment.
Would it be even better if we have a marco like: assert_disasm_snapshot!(cb, @" 0x0: add x0, x1, x2")?
Member
Author
There was a problem hiding this comment.
My understanding is that insta doesn't support updating a custom macro like that
Member
There was a problem hiding this comment.
Ah I see that makes sense. Thanks for the context 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
make zjit-teston builds that don't have thedisasmfeature.