ZJIT: Inline GuardNotFrozen into LIR #15251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Sigh. Shopify#876 |
k0kubun
reviewed
Nov 21, 2025
k0kubun
approved these changes
Nov 21, 2025
No sense calling a C function.
tekknolagi
force-pushed
the
mb-guard-not-frozen
branch
from
fbddc35 to
dc7d6f2
Compare
tekknolagi
force-pushed
the
mb-guard-not-frozen
branch
from
dc7d6f2 to
34b7228
Compare
eregon
reviewed
Nov 22, 2025
| self.assert_subtype(insn_id, val, types::BasicObject) | ||
| } | ||
| Insn::GuardNotFrozen { recv, .. } => { | ||
| self.assert_subtype(insn_id, recv, types::HeapBasicObject) |
Member
There was a problem hiding this comment.
Neat way to capture the precondition :)
Didn't know about HeapBasicObject, we could use that as the return type of GuardNotFrozen (even before this PR) but now that's automatic thanks to Insn::GuardNotFrozen { recv, .. } => self.type_of(*recv),
Contributor
Author
There was a problem hiding this comment.
That's true, didn't even think about that refinement beforehand!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No sense calling a C function.