Skip to content

Conversation

@naitoh
Copy link
Contributor

@naitoh naitoh commented Nov 27, 2025

#scan_integer was introduced at ruby/strscan#115
But it's not documented at https://docs.ruby-lang.org/en/master/StringScanner.html

See: ruby/strscan#176 (comment)

@kou
Copy link
Member

kou commented Nov 27, 2025

Ah, we can't preview generated docs before merge a PR?

@hsbt
Copy link
Member

hsbt commented Nov 27, 2025

Yes, it's hard to work only doc pull-request.

@kou
Copy link
Member

kou commented Nov 27, 2025

OK. Can we try this in master? (Can we merge this?)

@naitoh
Copy link
Contributor Author

naitoh commented Nov 27, 2025

@kou
Copy link
Member

kou commented Nov 27, 2025

OK. Let's merge this.

@kou kou merged commit 10522ca into ruby:master Nov 27, 2025
30 checks passed
@naitoh naitoh deleted the add_ext_document_strscan_lib branch November 27, 2025 06:02
@naitoh
Copy link
Contributor Author

naitoh commented Dec 2, 2025

This has been reflected in the document. 🎉
https://docs.ruby-lang.org/en/master/StringScanner.html#method-i-scan_integer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants