ZJIT: Fix test failures from line number of Primitive shifting
#15575
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry, I'm merging this without reviews to fix CI on the |
This can happen with documentation updates and we don't want those to trip on ZJIT tests. Redact the whole name since names like "_bi342" aren't that helpful anyways.
XrXr
force-pushed
the
zjit-primitive-line-shift
branch
from
17093a9 to
3b3ab33
Compare
Contributor
|
This is great for avoiding skew but not great for figuring out what these
are when doing performance or debugging work. Can we make the identifier
gen more stable instead?
…On Mon, Dec 15, 2025 at 10:19 PM matzbot ***@***.***> wrote:
Merged #15575 <#15575> into master.
—
Reply to this email directly, view it on GitHub
<#15575 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADB6D264RBX24RXX4QYNZ34B524LAVCNFSM6AAAAACPES464SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGU4DCOBTGU2DOOA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen with documentation updates and we don't want
those to trip on ZJIT tests.
Redact the whole name since names like "_bi342" aren't that helpful
anyways.