Fix corrupted lockfile when running bundle check and having to re-resolve locally#5344
Merged
deivid-rodriguez merged 1 commit intomasterfrom Feb 11, 2022
Conversation
deivid-rodriguez
changed the title
gemspec and multiple sourcesbundle check and having to re-resolve locally
deivid-rodriguez
deleted the
fix-lockfile-with-gemspec-directive-and-multiple-sources
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 23, 2022
…ctive-and-multiple-sources Fix corrupted lockfile when running `bundle check` and having to re-resolve locally (cherry picked from commit 46c9b07)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When running
bundle check, and re-resolving locally because the gemspec has changed, we need to make sure the sources set in the previous lockfile are preserved.What is your fix for the problem, implemented in this PR?
Add requirements from locked specs to source requirements when resolving locally.
Fixes #5339.
Make sure the following tasks are checked