Allow Bundler to run on old RubyGems + Ruby 2.7 without warnings #6187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can reintroduce this once Ruby 2.7 reaches end of life.
Contributor
|
I think this is good, and it is ok to trail ruby-core a little bit on support. In the old days, we supported all the way back to Ruby 1.8, mostly because it benefits us to be able to upgrade even very old users to new bundler version fixes or improvements. 👍🏻 |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 24, 2022
Allow Bundler to run on old RubyGems + Ruby 2.7 without warnings (cherry picked from commit d2da51c)
dentarg
added a commit
to spinels/overman
that referenced
this pull request
Dec 25, 2022
Apparently the tests are sensitive to the output, like what happened in ruby/setup-ruby#420 Saw this option in ruby/rubygems#6187
dentarg
added a commit
to spinels/overman
that referenced
this pull request
Feb 7, 2025
Apparently the tests are sensitive to the output, like what happened in ruby/setup-ruby#420 Saw this option in ruby/rubygems#6187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We may have been a little too aggressive here. Users running Ruby 2.7 which is still supported for a few months are getting this warning.
What is your fix for the problem, implemented in this PR?
Don't show the warning on Ruby 2.7. We can reintroduce this once Ruby 2.7 reaches end of life.
Make sure the following tasks are checked