Make Bundler never instantiate development dependencies #8486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/improve-error-message-on-incompatible-gemspec-development-dependencies
branch
from
9fd0afa to
626aa7c
Compare
4 tasks
Bundler does not really have a concept of "development dependencies", like RubyGems has. Bundler has the more generic concept of "groups". Under the hood, the `gemspec` DSL will put gemspec development dependencies under a `:development` Gemfile group, but there's no reason to instantiate these as development dependencies, they are regular runtime dependencies, except that they belong in a group named :development. By never instantiating development dependencies at all, we avoid having to introduce hacks to "undo" the type Bundler does not know about, and I also think the error messages read better.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/improve-error-message-on-incompatible-gemspec-development-dependencies
branch
from
626aa7c to
9a06fa5
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/improve-error-message-on-incompatible-gemspec-development-dependencies
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
…-message-on-incompatible-gemspec-development-dependencies Make Bundler never instantiate development dependencies (cherry picked from commit eaa9ad2)
ccutrer
added a commit
to ccutrer/rubygems
that referenced
this pull request
Apr 9, 2025
Since ruby#8486, hax to make any dependency type work inside bundler have been removed, so we mark plugins as type: :plugin. Instead, follow that PR's lead and just make it a dedicated option to Bundler::Dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
None, just want to make the code simpler and error messages read a bit better.
What is your fix for the problem, implemented in this PR?
Bundler does not really have a concept of "development dependencies", like RubyGems has. Bundler has the more generic concept of "groups".
Under the hood, the
gemspecDSL will put gemspec development dependencies under a:developmentGemfile group, but there's no reason to instantiate these as development dependencies, they are regular runtime dependencies, except that they belong in a group named :development.By never instantiating development dependencies at all, we avoid having to introduce hacks to "undo" the type Bundler does not know about, and I also think the error messages read better.
Make sure the following tasks are checked