Fix regression when running bundle update <foo> would sometimes downgrade a top level dependency
#8491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-unintended-downgrades
branch
from
11a185a to
4786c2b
Compare
These don't really hurt, so I'm not sure why I introduced it.
To make it consistent with the spec above it.
There's no reason to call `converge_specs` when adding additional lower bound requirements to prevent downgrades, and it actually causes the extra requirements to be missed sometimes. Loop over the originally locked specs directly, adding the additional precaution of not adding the requirement if the Gemfile dependency has changed and it no longer matches the locked spec.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-unintended-downgrades
branch
from
4786c2b to
5154506
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/fix-unintended-downgrades
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
…d-downgrades Fix regression when running `bundle update <foo>` would sometimes downgrade a top level dependency (cherry picked from commit 8fe5bae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Sometimes, running
bundle update <foo>would downgrade a top level dependency. Regression was introduced by d0f7899.What is your fix for the problem, implemented in this PR?
The fix is to avoid calling
converge_specswhen adding lower bound extra requirements to prevent downgrades. Using this method was causing the extra requirements to sometimes not be added.Fixes #8474.
This PR builds on top of #8489, so that PR should be merged first.
Make sure the following tasks are checked