Improve log messages when lockfile platforms are added #8523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current it says "you added a new platform to your gemfile", but that's not actually the case here.
And make it consistent with platform additions.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/improve-platform-changes-error-message
branch
from
d02c254 to
ad657ce
Compare
This message is printed when running `bundle lock --add-platform`. This command affects the lockfile, not the gemfile, and I think it's better to use "You are adding" rather than "You added", because the addition is happening during the current invocation (as opposed to other log messages that talk about a change made to the Gemfile prior to running the command).
deivid-rodriguez
force-pushed
the
deivid-rodriguez/improve-platform-changes-error-message
branch
from
ad657ce to
aba1e55
Compare
deivid-rodriguez
changed the title
deivid-rodriguez
deleted the
deivid-rodriguez/improve-platform-changes-error-message
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 11, 2025
…orm-changes-error-message Improve log messages when lockfile platforms are added (cherry picked from commit 1892fb9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I noticed that since #8489, we will print the following log message when Bundler is adding the current platform to the lockfile:
while before it would print
I think the previous message is better because you're not explicitly adding anything.
What is your fix for the problem, implemented in this PR?
Restore the previous message by not adding the local platform to the
@new_platformsarray when the addition is not explicit.On top of that, I changed the message when the addition is explicit (
bundle lock --add-platform) fromto
Finally, I also included a few changes to make adding and removing platforms more consistent.
Make sure the following tasks are checked