Skip to content

Make Set#pretty_print IRB::ColorPrinter friendly #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knu merged 1 commit into from
Aug 20, 2021
Merged

Make Set#pretty_print IRB::ColorPrinter friendly #17

knu merged 1 commit into from
Aug 20, 2021

Conversation

@k-tsj
Copy link
Member

@k-tsj k-tsj commented May 23, 2021

Before

before

After

after

olleolleolle
olleolleolle approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement.

@knu knu merged commit fbf3c99 into ruby:master Aug 20, 2021
@knu
Copy link
Member

knu commented Aug 20, 2021

Thanks!

@k-tsj
Copy link
Member Author

k-tsj commented Oct 3, 2021

@knu
It would be nice if you could merge this change into ruby/ruby by preview1 release.

Thanks.

@k-tsj
Copy link
Member Author

k-tsj commented Oct 3, 2021

Oops, it has been already merged. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@knu knu knu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k-tsj @knu @olleolleolle