Skip to content

Conversation

@jeremyevans
Copy link
Contributor

Since core Set did not make Ruby 3.5.0-preview1, this currently does some checking to see if Set is already defined and implemented in core. That can be removed after Ruby 3.5.0-preview2 is released.

Since core Set did not make Ruby 3.5.0-preview1, this currently does
some checking to see if Set is already defined and implemented in
core.  That can be removed after Ruby 3.5.0-preview2 is released.
@jeremyevans jeremyevans requested a review from knu as a code owner April 27, 2025 18:31
@byroot
Copy link
Member

byroot commented May 10, 2025

@knu could we merge and release this? Because right now any app including the set gem is fully broken on Ruby 3.5.0, so that hinders ruby-head testing.

@byroot
Copy link
Member

byroot commented May 10, 2025

Also cc @nurse and @hsbt as I see you are both owners of the gem.

TL;DR; it's very hard to test ruby-head right now because of this, and being able to test ruby-head is important to catch regressions early.

@jeremyevans
Copy link
Contributor Author

Is there a reason an application would want to add set to its Gemfile in a supported Ruby version? set was stdlib, never bundled gems, so the only reason to do so is if you wanted a different version of set than shipped with Ruby. Considering the release history of set, I'm not sure why an application would want to do that, but maybe I'm missing something.

@byroot
Copy link
Member

byroot commented May 10, 2025

Is there a reason an application would want to add set to its Gemfile in a supported Ruby version?

No, but you might end up with a dependency that does so. Right now this is happening in rails/rails because bunny depends on sorted_set which itself depends on set.

@hsbt hsbt merged commit e2daa08 into ruby:master May 12, 2025
13 checks passed
byroot added a commit to rails/rails that referenced this pull request May 12, 2025
byroot added a commit to rails/rails that referenced this pull request May 12, 2025
byroot added a commit to rails/rails that referenced this pull request May 12, 2025
byroot added a commit to rails/rails that referenced this pull request May 12, 2025
byroot added a commit to rails/rails that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants