Add Set#<=>
#5
Merged
Add Set#<=>
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
approved these changes
Oct 24, 2020
Member
knu
left a comment
knu
left a comment
There was a problem hiding this comment.
Considering Array has <=> yet is not Comparable, this looks reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compares only
Sets. Other classes (in particular array) can not be compared andnilis returned.The implementation of
<,>,subset?, etc., could all depend on<=>, but it is more efficient to keep them as is.a < bcan returnfalsewithout having to know the reason (is it thata > bor do they both have distinct elements).