Skip to content

Update guard from Ruby 3.5 -> 4 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyevans merged 2 commits into from
Dec 9, 2025
+2 −14
Merged

Update guard from Ruby 3.5 -> 4 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2036ed2
Update guard from Ruby 3.5 -> 4
jeremyevans Dec 8, 2025
87b9315
Hard code ruby versions to test on
jeremyevans Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,11 @@ name: test
on: [push, pull_request]

jobs:
ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby
min_version: 3.0
Copy link
Member

@knu knu Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame it does not support max_version...


build:
needs: ruby-versions
name: build (${{ matrix.ruby }} / ${{ matrix.os }})
strategy:
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
ruby: ["3.0", 3.1, 3.2, 3.3, 3.4]
os: [ ubuntu-latest, macos-latest ]
runs-on: ${{ matrix.os }}
steps:
Expand Down
7 changes: 1 addition & 6 deletions lib/set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
# frozen_string_literal: true

if RUBY_VERSION >= '3.5'
if defined?(Set) && defined?(Set.[]) && Set.method(:[]).source_location.nil?
# Remove defined? ... conditional after Ruby 3.5.0-preview2
return
end
end
return if RUBY_VERSION >= '4'

# :markup: markdown
#
Expand Down