Skip to content

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented Nov 27, 2024

This includes some additional updates:

  • Move old specs for refined_class to a shared spec, use this shared spec for target
  • Add a spec for Ruby 3.3 to check that refinement_target has been deprecated
  • Add a spec for Ruby 3.4 to check that refinement_target has been removed

Another checkbox for #1216

This includes some additional updates:

* Move old specs for refined_class to a shared spec, use this shared
  spec for target
* Add a spec for Ruby 3.3 to check that refinement_target has been
  deprecated
* Add a spec for Ruby 3.4 to check that refinement_target has been
  removed
@herwinw
Copy link
Member Author

herwinw commented Nov 27, 2024

I've tested the 3.4 specs with a very recent MRI build (ruby 3.4.0dev (2024-11-27T17:12:23Z master 0af2eafc59) +PRISM), since we don't have that one in the CI yet.

@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit 11d86bd into ruby:master Nov 27, 2024
14 checks passed
@herwinw herwinw deleted the refinement_target branch November 28, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants