Skip to content

Remove shared/rational folder, move specs inline #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eregon merged 1 commit into from
Dec 30, 2024
Merged

Remove shared/rational folder, move specs inline #1230

eregon merged 1 commit into from
Dec 30, 2024

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented Dec 30, 2024

This has become obsolete in 2015 when Rational was imported into core

Reference: commit 3ceb9ae

@herwinw
Remove shared/rational folder, move specs inline
09ab718 
This has become obsolete in 2015 when Rational was imported into core

Reference: commit 3ceb9ae
@herwinw
Copy link
Member Author

herwinw commented Dec 30, 2024

../mspec/bin/mspec core/rational outputs the same number of examples and expectations as master

eregon
eregon approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

@eregon eregon merged commit 34ce2eb into ruby:master Dec 30, 2024
14 checks passed
@herwinw herwinw deleted the rational_shared branch December 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@herwinw @eregon