Improve spec for MatchData#offset #1293
Merged
+89
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
reviewed
Nov 6, 2025
| m = /\A\u3042(.)(.)?(.)\z/.match("\u3042\u3043\u3044") | ||
|
|
||
| m.offset(2).should == [nil, nil] | ||
| end |
Member
There was a problem hiding this comment.
I suppose all the regexps with Unicode codepoints in it (like /\A\u3042..) have UTF-8 encoding and are not supported by Opal. So it makes sense at least to add a version guard for such cases.
Member
There was a problem hiding this comment.
Ah, the similar test cases for #byteoffset aren't guarded. Nevermind.
Contributor
Author
There was a problem hiding this comment.
Hmm, true. Spec for #byteoffset doesn't have any guards however, so I'm not sure what is the point here exactly.
andrykonchin
approved these changes
Nov 6, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1292, I noticed that spec for
#offsetis missing a lot of cases that are present in spec for#byteoffset, in particular named captures. So I replaced the spec with that one with appropriate changes, retaining only the special test for Unicode Regexp which apparently doesn't work on Opal.