Adds coverage for KeyError#receiver / KeyError#key #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 28, 2017 14:52
Part of ruby#565, this implements Feature 12063: KeyError#receiver / KeyError#key
eregon
reviewed
Dec 29, 2017
core/hash/fetch_spec.rb
Outdated
| @key = :a | ||
| end | ||
|
|
||
| it "sets the Hash as the reciever of KeyError" do |
core/hash/fetch_spec.rb
Outdated
| } | ||
| end | ||
|
|
||
| it "sets the key attempted as key of KeyError" do |
Member
There was a problem hiding this comment.
sets the not-found key is maybe a bit clearer.
61 tasks
Contributor
Author
|
Updated per review. 😄 |
Member
|
I am thinking we might be able to used shared specs, and pass a lambda which triggers the KeyError. |
Contributor
Author
|
Sure, makes sense. I'll give it a go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #565, this implements Feature 12063: KeyError#receiver / KeyError#key from Ruby 2.5.0 release.