build: use non-deprecated compiler flag when building jruby extension #202
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
fix-jruby-ext-build
branch
from
1e88d06 to
682431b
Compare
Member
|
Thanks. |
Contributor
Author
|
Any time @kou - thanks for all the regular ongoing support and work! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build uses deprecated Java compiler flags which do not fully guarantee runtime compatibility with the targeted Java runtime version.
it doesn't cause any issues right now as the Java extension code is limited; but this would be better practice; especially as builds are executed with a non-locked Java runtime determined by
setup-rubydefaults.