-
Notifications
You must be signed in to change notification settings - Fork 43
CI: Use shared versions GH Actions workflow #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I took some inspiration from https://github.com/ruby/uri/blob/master/.github/workflows/test.yml and then I edited the necessary values.
We now use the versions workflow. This means that that value is fixed, this YAML file needing no further updates.
|
FYI, CI fails on jruby latest release, tracked as #75 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@headius Do we need both of jruby and jruby-head?
|
I learned about the JRuby detail:
And by "the new version" headius is referring to the Joni library version. And that should be removed.
In order to begin, I started a Draft PR, #76. |
|
I have merged #76 and master is now green on latest JRuby. |
|
@olleolleolle Thanks for the PR! |
|
In #82, kou explained the reason for the failed builds on current master (and also in this PR). I will merge this, now. Thanks, all, for helping! |
fix #73
I took some inspiration from https://github.com/ruby/uri/blob/master/.github/workflows/test.yml and then I edited the necessary values.
(I put this as a Draft PR, since I am not sure about all the details, which engines and versions will be included.)