Skip to content

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 8, 2024

fix #73

I took some inspiration from https://github.com/ruby/uri/blob/master/.github/workflows/test.yml and then I edited the necessary values.

(I put this as a Draft PR, since I am not sure about all the details, which engines and versions will be included.)

We now use the versions workflow.

This means that that value is fixed, this YAML file needing no further updates.
@eregon
Copy link
Member

eregon commented Jan 8, 2024

FYI, CI fails on jruby latest release, tracked as #75

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headius Do we need both of jruby and jruby-head?

@olleolleolle olleolleolle marked this pull request as ready for review January 8, 2024 16:15
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jan 9, 2024

I learned about the JRuby detail:

Yeah we had a transition period where it supported both old and new but now all released JRuby should be on the new version.

And by "the new version" headius is referring to the Joni library version.

And that should be removed.

// Provided temporarily to bridge the gap between joni 2.1 and 2.2

In order to begin, I started a Draft PR, #76.

@headius
Copy link
Contributor

headius commented Jan 14, 2024

I have merged #76 and master is now green on latest JRuby.

@headius
Copy link
Contributor

headius commented Jan 14, 2024

@olleolleolle Thanks for the PR!

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Jan 15, 2024

In #82, kou explained the reason for the failed builds on current master (and also in this PR).

I will merge this, now. Thanks, all, for helping!

@olleolleolle olleolleolle merged commit 1f304d7 into master Jan 15, 2024
@olleolleolle olleolleolle deleted the ci-use-ruby-workflow-for-versions branch January 15, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: perhaps we need Ruby 3.3 in the matrix

5 participants