Skip to content

Optimize scan_byte and peek_byte #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Feb 27, 2024
Merged

Optimize scan_byte and peek_byte #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions ext/jruby/org/jruby/ext/strscan/RubyStringScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,26 +513,27 @@ public IRubyObject scan_byte(ThreadContext context) {
Ruby runtime = context.runtime;
check(context);
clearMatched();
if (curr >= str.getByteList().getRealSize()) return context.nil;

byte[] bytes = str.getBytes();
ByteList byteList = str.getByteList();
int curr = this.curr;
if (curr >= byteList.getRealSize()) return context.nil;

byte bite = bytes[curr];
int bite = byteList.get(curr);
prev = curr;
curr++;
this.curr++;

setMatched();
adjustRegisters();
return RubyFixnum.newFixnum(context.runtime, bite & 0xff);
return RubyFixnum.newFixnum(runtime, bite);
}

@JRubyMethod(name = "peek_byte")
public IRubyObject peek_byte(ThreadContext context) {
Ruby runtime = context.runtime;
check(context);
if (curr >= str.getByteList().getRealSize()) return context.nil;
ByteList byteList = str.getByteList();
int curr = this.curr;
if (curr >= byteList.getRealSize()) return context.nil;

return RubyFixnum.newFixnum(context.runtime, (str.getBytes()[curr]) & 0xff);
return RubyFixnum.newFixnum(context.runtime, byteList.get(curr));
}

@JRubyMethod(name = "peek")
Expand Down