Failing test for aspirational perf improvements #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is 9k lines long and even with the currently optimized algorithm takes about 1.6s to search. The goal is to find a way to get it under 1 second. If someone is working with such large files they can set their DEAD_END_TIMEOUT=2 and be perfectly fine, but perf improvements that would allow this file to parse under 1 second would hopefully also speed up other cases.
schneems
force-pushed
the
schneems/partition
branch
from
094f202 to
86a3b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is 9k lines long and even with the currently optimized algorithm takes about 1.6s to search. The goal is to find a way to get it under 1 second.
If someone is working with such large files they can set their DEAD_END_TIMEOUT=2 and be perfectly fine, but perf improvements that would allow this file to parse under 1 second would hopefully also speed up other cases.