Fix AroundBlockScan #131
Merged
Fix AroundBlockScan #131
+94
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were accidentally not using the persisted @before_index and instead using the "original" before index. This commit fixes that problem and adds a test for the behavior.
schneems
force-pushed
the
schneems/fix-around-block-before-index
branch
from
289cb0c to
ad8b2bd
Compare
When scanning returns nothing, the block position should not change.
This refactor removes the need to allocate an extra AroundBlockScan. Not a big hotspot, but it's not needed either.
Calling `send` and iterating over an array is not great. We're only dealing with 2 cases, we can explicitly handle both of them.
We're already skipping `hidden?` we don't need to call the method again.
Experimenting with this approach (not a hotspot).
schneems
force-pushed
the
schneems/fix-around-block-before-index
branch
from
084bf6f to
b579f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were accidentally not using the persisted @before_index and instead using the "original" before index. This commit fixes that problem and adds a test for the behavior.