Stop warning when on eval & streaming code #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a syntax error inside of an eval, but the parent code is valid a syntax error is raised inside of the eval instead of inside the parent code. When this happens Ruby thinks the filename is
(eval)but this does not exist on disk so dead end cannot read it. Here's the current behavior:Since we will never be able to read
(eval):1we can special case this "file name" and skip emitting the warning.Same problem with code that is streamed to ruby:
However we're not currently capturing this error due to #31.
You can still get a warning by using
DEBUG=1environment variable for these cases in case there is a bug in this behavior and we need to debug it.