Fix yjit support #144
Merged
Fix yjit support #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason yjit tests on ruby/ruby are failing against the current code: ``` $ time RUBY_YJIT_ENABLE=1 RUBY_TESTOPS="-q --tty=no" make -s check RUN_OPTS="" # ... # Fails ``` While this works without yjit enabled it seems the problem is related to an error happening within the `SyntaxError#detailed_message`. It also seems that the other part of the equation is `autoload` with a gem on disk (instead of something in the stdlib). One immediate fix is to ensure that if there are any internal errors, that the original syntax error always takes precedent. I've tried to reproduce the failure removing dead_end but I'm unable to, so I want to move ahead. If we find dead_end does not work with YJIT in cases in the future then the YJIT team (and I) can investigate.
schneems
added a commit
to schneems/ruby
that referenced
this pull request
May 27, 2022
From ruby/syntax_suggest#144 Fixes error: ``` F#1438 test_syntax.rb:630: $stderr = STDOUT eval("\"\xf0".force_encoding("utf-8")) #=> /invalid multibyte char/ expected to be =~ "bootstraptest.test_syntax.rb_630_1438.rb:3:in `eval': SyntaxError\n\tfrom bootstraptest.test_syntax.rb_630_1438.rb:3:in `<main>'\n" [ruby-dev:32429] FAIL 1/1735 tests failed make: *** [uncommon.mk:777: yes-btest-ruby] Error 1 ``` From https://github.com/ruby/ruby/runs/6576796660?check_suite_focus=true
schneems
added a commit
to schneems/ruby
that referenced
this pull request
Jun 4, 2022
From ruby/syntax_suggest#144 Fixes error: ``` F#1438 test_syntax.rb:630: $stderr = STDOUT eval("\"\xf0".force_encoding("utf-8")) #=> /invalid multibyte char/ expected to be =~ "bootstraptest.test_syntax.rb_630_1438.rb:3:in `eval': SyntaxError\n\tfrom bootstraptest.test_syntax.rb_630_1438.rb:3:in `<main>'\n" [ruby-dev:32429] FAIL 1/1735 tests failed make: *** [uncommon.mk:777: yes-btest-ruby] Error 1 ``` From https://github.com/ruby/ruby/runs/6576796660?check_suite_focus=true
schneems
added a commit
to schneems/ruby
that referenced
this pull request
Jul 26, 2022
From ruby/syntax_suggest#144 Fixes error: ``` F#1438 test_syntax.rb:630: $stderr = STDOUT eval("\"\xf0".force_encoding("utf-8")) #=> /invalid multibyte char/ expected to be =~ "bootstraptest.test_syntax.rb_630_1438.rb:3:in `eval': SyntaxError\n\tfrom bootstraptest.test_syntax.rb_630_1438.rb:3:in `<main>'\n" [ruby-dev:32429] FAIL 1/1735 tests failed make: *** [uncommon.mk:777: yes-btest-ruby] Error 1 ``` From https://github.com/ruby/ruby/runs/6576796660?check_suite_focus=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason yjit tests on ruby/ruby are failing against the current code:
While this works without yjit enabled it seems the problem is related to an error happening within the
SyntaxError#detailed_message. It also seems that the other part of the equation isautoloadwith a gem on disk (instead of something in the stdlib).One immediate fix is to ensure that if there are any internal errors, that the original syntax error always takes precedent. I've tried to reproduce the failure removing dead_end but I'm unable to, so I want to move ahead. If we find dead_end does not work with YJIT in cases in the future then the YJIT team (and I) can investigate.