Skip to content

No longer need PathnameFromMessage with SyntaxError#path. #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schneems merged 1 commit into from
Dec 1, 2022
Merged

No longer need PathnameFromMessage with SyntaxError#path. #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/syntax_suggest/core_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,12 @@ def detailed_message(highlight: true, syntax_suggest: true, **kwargs)
require "syntax_suggest/api" unless defined?(SyntaxSuggest::DEFAULT_VALUE)

message = super
file = if highlight
SyntaxSuggest::PathnameFromMessage.new(super(highlight: false, **kwargs)).call.name
else
SyntaxSuggest::PathnameFromMessage.new(message).call.name
end

io = SyntaxSuggest::MiniStringIO.new
file = path

if file
file = Pathname.new(file)
io = SyntaxSuggest::MiniStringIO.new

SyntaxSuggest.call(
io: io,
source: file.read,
Expand Down