Drop support for old 3.2.0 preview versions #165
Merged
+84
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.2.0rc1 introduced SyntaxError#path in addition to the ability to monkey patch SyntaxError. That means all code inside of this syntax error is guaranteed to be on Ruby 3.2. As the contents of the preview release were unstable, we do not have to continue to support older preview releases that did not contain SyntaxError#path
schneems
force-pushed
the
schnems/remove-legacy-preview-paths
branch
from
86ba726 to
59f2304
Compare
Since syntax_suggest is now integrated with Ruby as a default gem it is now a bit tougher to test. The default gem monkeypatches SyntaxError so when it's monkey patched again via the gem the result will be different. This change moves the module into a method that can be used to prepend any class for testing so we can assert behavior against our code in isolation while integration tests assert with the full stack.
schneems
force-pushed
the
schnems/remove-legacy-preview-paths
branch
from
59f2304 to
d6fc460
Compare
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2.0rc1 introduced SyntaxError#path in addition to the ability to monkey patch SyntaxError. That means all code inside of this syntax error is guaranteed to be on Ruby 3.2. As the contents of the preview release were unstable, we do not have to continue to support older preview releases that did not contain SyntaxError#path