More efficient frontier unvisited line structure #39
+47
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/new-frontier
branch
from
2bc135a to
9fe6916
Compare
schneems
force-pushed
the
schneems/new-frontier
branch
from
9fe6916 to
25c3e58
Compare
Previously we were keeping track of the lines that were not in the frontier via an @indent_hash with the keys as indentation and value as an array. This was inefficient and caused us to constantly be sorting the keys. Instead we can get the same information by only sorting once. As a bonus perf optimization CodeLine#indent_index generates a key for stable sort and memoizes it so it only has to be allocated once per line.
schneems
force-pushed
the
schneems/new-frontier
branch
from
25c3e58 to
dbb8520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were keeping track of the lines that were not in the frontier via an @indent_hash with the keys as indentation and value as an array.
This was inefficient and caused us to constantly be sorting the keys. Instead, we can get the same information by only sorting once.
As a bonus perf optimization, CodeLine#indent_index generates a key for stable sort and memoizes it so it only has to be allocated once per line.