Safer NoMethodError annotation #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a NoMethodError was raised from within the DeadEnd monkeypatch then an infinite loop would be caused by calling `e.message` since that would trigger our monkeypatch recursively. This patch fixes the issue by aliasing the original method and explicitly using that instead. This behavior is also tested. So while there still might be internal errors, at least they won't result in infinite loops with no output.
schneems
force-pushed
the
schneems/safer-no-method-error
branch
from
5859239 to
a1e4263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a NoMethodError was raised from within the DeadEnd monkeypatch then an infinite loop would be caused by calling
e.messagesince that would trigger our monkeypatch recursively.This patch fixes the issue by aliasing the original method and explicitly using that instead.
This behavior is also tested. So while there still might be internal errors, at least they won't result in infinite loops with no output.