Add compatibility with zeitwerk #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as this one zombocom/derailed_benchmarks@88b33a0 H/t to @engwan I'm honestly not 100% the full chain of events that cause this. Some other history is: - zombocom/derailed_benchmarks#128 @engwan do you know of a way I could make this fail in a similar way without Rails so I could add a test?
schneems
force-pushed
the
module_function
branch
from
7a37d01 to
61cfa36
Compare
|
Hmm.. I'm not really sure why it's causing the private method error. I don't understand how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as this one zombocom/derailed_benchmarks@88b33a0
H/t to @engwan
I'm honestly not 100% the full chain of events that cause this. Some other history is:
@engwan do you know of a way I could make this fail in a similar way without Rails so I could add a test?