Return non-zero status code on exceptions found #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirroring the behavior from `ruby -wc` the command line now returns non-zero exit codes when it finds a syntax error:
```
$ ruby -wc /tmp/scratch.rb
/tmp/scratch.rb:3: syntax error, unexpected `end', expecting ']'
$ echo $?
1
```
New behavior:
```
$ ./exe/dead_end /tmp/scratch.rb
DeadEnd: Unmatched `]` detected
file: /tmp/scratch.rb
simplified:
1 def foo
❯ 2 foo = [ 1,1,1
3 end
$ echo $?
1
```
The alternative to this logic would be to return 0 for all cases unless an internal error happens.
This change will allow the vscode extension to use an exit code rather than relying on output strings https://github.com/zombocom/dead_end-vscode/blob/2f2560a073c93015e05d0baab0bf5e2853866e0f/extension.js#L16.
schneems
force-pushed
the
schneems/exe-exit-code
branch
from
2fc40e8 to
3b69591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the behavior from
ruby -wcthe command line now returns non-zero exit codes when it finds a syntax error:New behavior:
The alternative to this logic would be to return 0 for all cases unless an internal error happens.
This change will allow the vscode extension to use an exit code rather than relying on output strings https://github.com/zombocom/dead_end-vscode/blob/2f2560a073c93015e05d0baab0bf5e2853866e0f/extension.js#L16.