Global #timeout was removed 5 years ago #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also update Timeout::timeout to the more common format of Timeout.timeout
jpcamara
changed the title
olleolleolle
approved these changes
Aug 28, 2024
Contributor
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
This fixes the README's accuracy, and also keeps the example code looking current. Thank you!
Member
|
Does anyone update https://github.com/ruby/timeout/blob/master/lib/timeout.rb#L16 too? Thanks |
olleolleolle
added a commit
that referenced
this pull request
Aug 28, 2024
This is a followup to #49.
olleolleolle
added a commit
that referenced
this pull request
Aug 28, 2024
This is a followup to #49.
Contributor
Author
|
Thanks! I also updated the ruby docs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent like 45 minutes trying to figure out why the top-level
timeoutdidn't work, and then spent more time trying to figure out how it possibly could work based on the current code 😅 . Turns out it was removed years ago - so this updates the docs to reflect that.