Allow Zlib.crc32 and .adler32 to accept IO instance #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reads from the IO in 8192 byte chunks, so you don't need to have the entire string in memory. Fixes ruby#16
nurse
approved these changes
Oct 28, 2020
Member
nurse
left a comment
nurse
left a comment
There was a problem hiding this comment.
Generally looks good to me. You can merge this after a tiny fix
ext/zlib/zlib.c
Outdated
| else if (rb_obj_is_kind_of(str, rb_cIO)) { | ||
| VALUE buf; | ||
| VALUE buflen = INT2NUM(8192); | ||
| ID meth = rb_intern("read"); |
Member
There was a problem hiding this comment.
id_read is defined in this file; use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads from the IO in 8192 byte chunks, so you don't need to
have the entire string in memory.
Fixes #16