Make CodeManifest.load_manifes publict #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubaxenor
force-pushed
the
xc-make-load-file-public
branch
from
0075e63 to
2b54313
Compare
urnicus
reviewed
Jun 13, 2024
| diff-lcs (>= 1.2.0, < 2.0) | ||
| rspec-support (~> 3.11.0) | ||
| rspec-support (3.11.1) | ||
| stringio (3.1.0) |
There was a problem hiding this comment.
This is resulting in build failures in PBB
/usr/local/lib/ruby/3.3.0/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated stringio 3.1.0, but your Gemfile requires stringio 3.1.1. Since stringio is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports stringio as a default gem. (Gem::LoadError)
Contributor
Author
There was a problem hiding this comment.
The main reason here is to remove the YAML patch in https://github.com/rubyatscale/code_manifest/pull/5/files#diff-2aac61581ea2d39514c7db56a64c654b251315a2c74ec6e251e41ba75acabff4L48-L52 which was built-in in psych 4.
The problem here is that psych puts default gem as dependency: ruby/psych#525 Also from a gem's perspective, I don't think this change on code_manifest is inappropriate since we do want to only support psych >= 4.0.
I think the better way to tackle this is to make sure a gem update --system ran before bundle install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So others can reuse it to load different manifest file.