[0.14.3] Support custom save_path option#217
Merged
route merged 2 commits intorubycdp:masterfrom Nov 16, 2022
Merged
Conversation
Allows paths other than Capybara.save_path to be specified
b987718 to
12e34ec
Compare
Contributor
Author
|
Hey @route! 👋 Hope you're doing well. Thanks for your fantastic work maintaining this Gem, it's super helpful and really appreciated! 🙇 If you get some time, would you be able to evaluate if this is able to be merged in please, hopefully it helps someone else out and I can retire our fork 🍴 Thanks! |
Contributor
Author
|
Related issue: #198 |
Member
|
The tests are all failing |
Contributor
Author
|
Ah, thanks for approving them to run. I'll take a look! |
Contributor
Author
|
Thanks @route! - 🎉 😃 I was just about to ask you to re-run the tests as they were passing on my fork, but you've already done it 🚀 🪨 And have a great rest of your day! 🌤️ |
Member
|
Thank you! You too! |
cbliard
added a commit
to opf/openproject
that referenced
this pull request
Sep 19, 2024
rubycdp/cuprite#217 has been merged, `save_path` is correctly taken into account now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows paths other than Capybara.save_path to be specified
This PR allows a custom save_path option to be configured, instead of defaulting to the Capybara.save_path.
The motivation is wanting to specify an ephemeral directory for downloads (PDFs, CSVs etc) which is cleared between tests, but keep other items saved to the Capybara.save_path (like screenshots) as CI artifacts.
This is especially useful when running multiple specs on a single instance. Here is how we separate the downloads using this patch:
Original PR: #192 (this one has just rebased against 0.14.3)