detect if element to be acted on is actually on top/viewable#251
Merged
route merged 1 commit intorubycdp:mainfrom Nov 10, 2023
Merged
detect if element to be acted on is actually on top/viewable#251route merged 1 commit intorubycdp:mainfrom
route merged 1 commit intorubycdp:mainfrom
Conversation
Member
|
tests are failing, can you rebase on master? |
ryanong
force-pushed
the
click-overlay
branch
from
96d3248 to
478fcbf
Compare
Contributor
Author
|
It needs a bit more work... hold on before you run again |
ryanong
force-pushed
the
click-overlay
branch
from
478fcbf to
b575080
Compare
Contributor
Author
|
okay good to go |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #220
If the element is in the viewport it now checks to see if the element is actually the top element and clickable.
scrollIntoViewportand_isInViewportare now not name well but I am also unsure what else to name them.scrollIntoActionableViewPortand_isInActionableViewport?